-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontendのリファクタリング #355
frontendのリファクタリング #355
Conversation
typescriptで対応できると思ったのでbabel周り一旦無くしました |
import { chkColors } from "./../commons/color"; | ||
import ChkButtonBase from "./../commons/ChkButtonBase"; | ||
import { color, device } from "@/constants/styles"; | ||
import ChkButtonBase from "@/components/atoms/Buttons/ChkButtonBase"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こんな感じで @
を使ってimportできるようになりました
../../
みたいに相対指定しなくて大丈夫です
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全部把握しきれないので信じる気持ちを胸にApproveします
嬉しい |
WHY
乱雑になってきていたので一回整理したかった
WHAT
やったこと
prettier
printWidth: 120 -> 80
webpack
@
awesome-typescript-loader -> ts-loader
tslint-loader
package.json
if added file is *.{js,ts,tsx}, yarn lint && git add
tsconfig.json
tsconfig.json
commonjs -> es2015
all source code
import * as React from 'react" -> import React from 'react"
directory architecture
frontend/src/entries/ -> frontend/src/pages/
frontend/src/commons/ -> frontend/src/constants/
frontend/src/components/
:frontend/src/components/atoms
frontend/src/components/
:frontend/src/components/molecules
etc
goodSpace
やってないこと