feature/dockerizeの修正 #340
Merged
feature/dockerizeの修正 #340
+55
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanyou0311
reviewed
May 10, 2019
docker-compose.yml
Outdated
| volumes: | ||
| - ./:/code | ||
| ports: | ||
| - "3000:3000" | ||
| links: | ||
| - "db" | ||
| depends_on: |
There was a problem hiding this comment.
links 設定してあるので depends_on は不要なはず
docker/backend/Dockerfile.dev
Outdated
| @@ -11,21 +11,20 @@ ENV RUNTIME_PACKAGES="bash git perl libxml2-dev libxslt-dev libstdc++ tzdata mar | |||
| RUN apt-get update -qq | |||
| RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends apt-utils | |||
| RUN apt-get install -y libpq-dev graphviz imagemagick | |||
| RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - && apt-get install -y nodejs build-essential | |||
| RUN npm install -g yarn | |||
| # RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - && apt-get install -y nodejs build-essential | |||
There was a problem hiding this comment.
この辺のコメントは消しておいてよいかと！！ どうしても参照したくなったらログ見ればよいので
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
やったこと
やってないこと