Update tail from hpcloud/tail to nxadm/tail #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it does not always detect rotated logfiles. There are many issues in hpcloud/tail which are not addressed, hpcloud/tail looks dead. nxadm/tail is a fork which solved many known issues.
|
This is a critical issue with the continued use of the abandoned hpcloud version of tail. The drop-in replacement of nxadm/tail does fix the issues present in the hpcloud version. @BartVerc @tommie - Can someone please take a look at this and merge? This indeed does fix the issue of detecting and continuing to read rotated log files. |
tommie
reviewed
Aug 16, 2021
tommie
approved these changes
Aug 16, 2021
|
@tommie - Cheers mate! @BartVerc @Ivaylo-Korakov @flyhard - I see you each have merged commits over the past year or so. Could one of you please have a look at this PR? Cheers!!! And thank you for all the work developing and maintaining this extremely useful exporter for us all to use! |
|
Thanks for the fix! And sorry for the late response! |
chas0amx
pushed a commit
to chas0amx/postfix_exporter
that referenced
this pull request
Jun 16, 2024
Update tail from hpcloud/tail to nxadm/tail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it does not always detect rotated logfiles. There are many issues in hpcloud/tail which are not addressed, hpcloud/tail looks dead. nxadm/tail is a fork which solved many known issues.
Fixes: #78