ci(github): add workflow to check ci stability of release branches #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartsmykla
added
the
ci/skip-test
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
bartsmykla
force-pushed
the
ci/add-gh-action-to-check-ci-stability-of-release-branches
branch
6 times, most recently
from
78c56d7 to
3ce6028
Compare
…atch We decided to run daily tests for release branches to monitor stability. This change adds a new workflow in the master branch that triggers CI on release branches using the `workflow_dispatch` event. The schedule is: - release-A: 11:00 AM PST / 20:00 CET / 03:00 CST - release-B: 01:00 PM PST / 22:00 CET / 05:00 CST - release-C: 03:00 PM PST / 00:00 CET / 07:00 CST - release-D: 05:00 PM PST / 02:00 CET / 09:00 CST Each branch's `build-test-distribute` workflow was already updated earlier to support `workflow_dispatch`. The new master workflow uses the GitHub API to trigger these workflows. This ensures we are able to check branch stability with minimal changes and no interruptions to ongoing work. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
force-pushed
the
ci/add-gh-action-to-check-ci-stability-of-release-branches
branch
from
3ce6028 to
7acfb17
Compare
bartsmykla
requested review from
michaelbeaumont
and removed request for
a team
8 tasks
Signed-off-by: Bart Smykla <[email protected]>
lukidzi
reviewed
Dec 12, 2024
| group: ${{ format('{0}-{1}', github.workflow, github.event_name) }} | ||
|
|
||
| jobs: | ||
| fetch-release-branches: |
There was a problem hiding this comment.
WDYT about: get-active-branches?
There was a problem hiding this comment.
but it's not active branches, because we are excluding master
| branches: ${{ steps.generate-branches.outputs.branches }} | ||
| steps: | ||
| - name: Fetch release branches | ||
| id: generate-branches |
| exit 1 | ||
| fi | ||
|
|
||
| validate-schedule: |
There was a problem hiding this comment.
Not sure if validate-schedule maybe schedule-branch, since you match branch to the schedule
| run: | | ||
| BRANCH="" | ||
| case "$SCHEDULED_TIME" in | ||
| "0 19 * * *") BRANCH=$(echo "$RELEASE_BRANCHES" | jq -r '.[0]') ;; |
There was a problem hiding this comment.
Can we have more than 4 branches? I feel like 5 can be max but what about LTS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We decided to run daily tests for release branches to monitor stability. This change adds a new workflow in the master branch that triggers CI on release branches using the
workflow_dispatchevent. The schedule is:Each branch's
build-test-distributeworkflow was already updated earlier to supportworkflow_dispatch. The new master workflow uses the GitHub API to trigger these workflows. This ensures we are able to check branch stability with minimal changes and no interruptions to ongoing work.Supporting documentation
Part of: