Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(update-insecure-dependencies): fix osv-scanner failure #11983

Merged
merged 3 commits into from
Nov 6, 2024
Merged

ci(update-insecure-dependencies): fix osv-scanner failure #11983

merged 3 commits into from
Nov 6, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 6, 2024 •
edited
Loading

Motivation

Fails atm:

Scanned /home/runner/work/kuma/kuma/go.mod file and found 222 packages
panic: Cannot range over: func(yield func(K, V) bool)

goroutine 40815 [running]:
golang.org/x/tools/go/ssa.(*builder).rangeStmt(0xc0053d0770, 0xc0ea4c1520, 0xc006c5cd20, 0x0)
	/home/runner/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2279 +0x805
golang.org/x/tools/go/ssa.(*builder).stmt(0xc0053d0770, 0xc0ea4c1520, {0x1911160?, 0xc006c5cd20?})
	/home/runner/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2503 +0x205
golang.org/x/tools/go/ssa.(*builder).stmtList(...)
	/home/runner/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:909
golang.org/x/tools/go/ssa.(*builder).stmt(0xc0053d0770, 0xc0ea4c1520, {0x191
...

See successful run

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 6, 2024 11:02
@michaelbeaumont michaelbeaumont requested review from bartsmykla and lukidzi and removed request for a team November 6, 2024 11:02
bartsmykla
bartsmykla approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for looking into it!

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) November 6, 2024 11:05
@michaelbeaumont michaelbeaumont merged commit 409f75c into master Nov 6, 2024
13 checks passed
@michaelbeaumont michaelbeaumont deleted the ci/fix-osv-scanner branch November 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @bartsmykla