fix(k8s): set annotation kuma.io/display-name for Secrets and Configs (backport of #11923) #11941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kumahq[bot]](https://avatars.githubusercontent.com/u/67433617?s=60&v=4){kind=small}
…#11923) Otherwise we have issues if the Secret name is too long, already handled for other resources in #10430 Also this internally fixes `UpdateWithLabels` not being applied for secrets. Signed-off-by: Mike Beaumont <[email protected]>
kumahq
bot
requested review from
michaelbeaumont and
lukidzi
and removed request for
a team
slonka
reviewed
Oct 31, 2024
michaelbeaumont
added a commit
that referenced
this pull request
Nov 8, 2024
…1954) Needed for #11941 Automatic cherry-pick of #10335 for branch release-2.7 Generated by [action](https://github.com/kumahq/kuma/actions/runs/11608845773) Signed-off-by: Jakub Dyszkiewicz <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
…rt-release-2.7-11923 Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
chore/backport-release-2.7-11923
branch
from
a0b34f3 to
b505ea9
Compare
michaelbeaumont
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of #11923 for branch release-2.7
Generated by action
cherry-picked commit e1179af