Improvements to doc on control plane installation #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jijiechen
requested review from
bartsmykla and
lobkovilya
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lahabana
reviewed
Nov 7, 2023
lahabana
reviewed
Nov 7, 2023
lahabana
reviewed
Nov 7, 2023
|
Please hold on, I'll rebase from the new master with 2.5.x docs. |
…helm Signed-off-by: Jay Chen <[email protected]>
…named after v1.2.x Signed-off-by: Jay Chen <[email protected]>
…l plane when running on Kubernetes Signed-off-by: Jay Chen <[email protected]>
…MAY cause data plane failures Signed-off-by: Jay Chen <[email protected]>
…to 2.2.x, 2.3.x and 2.4.x Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
jijiechen
force-pushed
the
installation-improvements
branch
from
2582b0a to
2283d92
Compare
This is done now. |
lahabana
changed the title
lahabana
reviewed
Nov 7, 2023
lahabana
reviewed
Nov 7, 2023
lahabana
reviewed
Nov 7, 2023
lahabana
reviewed
Nov 7, 2023
lahabana
reviewed
Nov 7, 2023
lahabana
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
@jijiechen BTW in the future no need to update docs for non "single version" docs. These are considered deprecated versions and we should update the docs.
Signed-off-by: Charly Molter <[email protected]>
lahabana
reviewed
Nov 7, 2023
Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you sign your commit? Instructions
Have you read Contributing guidelines?
This fixes #1509