fix(deps): uses defineSlots macro over useSlots #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Cowen <[email protected]>
johncowen
commented
Jan 21, 2025
| @@ -29,21 +29,20 @@ | |||
| <template | |||
| v-for="key in Object.keys(slots)" | |||
| :key="key" | |||
| #[key]="{ row, rowValue }" | |||
There was a problem hiding this comment.
We don't use rowValue anywhere so I removed it.
Nice! I guess we could lint for these things (in this case |
Sounds good 👍 🙂 |
johncowen
merged commit 7b6ab0f
into
kumahq:dependabot/npm_and_yarn/vue-tsc-2.2.0
11 checks passed
johncowen
added a commit
that referenced
this pull request
Jan 22, 2025
Required for #3336 I got a bit more time to look at #3336 and it looks like Vue folks are moving more and more to macro-based `defineSlots` for defining slots. Moving everything to use defineSlots worked in most areas and I only had to define the types also for areas where we actually need the type information, otherwise defineSlots is a `Record<string, any>` (see https://vuejs-language-tools.vercel.app/features/slots#how-to-handle-indeterminate-slot-types) There 'may' be some other places where it would be advantageous to define our slots as more than `Record<string, any>` but for the moment this is enough to unblock the upgrade. We can add any more type information if required in later PRs. Also see https://vuejs.org/api/sfc-script-setup#defineslots Signed-off-by: John Cowen <[email protected]>
johncowen
pushed a commit
that referenced
this pull request
Jan 22, 2025
From #3444 I got a bit more time to look at #3336 and it looks like Vue folks are moving more and more to macro-based `defineSlots` for defining slots. Moving everything to use defineSlots worked in most areas and I only had to define the types also for areas where we actually need the type information, otherwise defineSlots is a `Record<string, any>` (see https://vuejs-language-tools.vercel.app/features/slots#how-to-handle-indeterminate-slot-types) There 'may' be some other places where it would be advantageous to define our slots as more than `Record<string, any>` but for the moment this is enough to unblock the upgrade. We can add any more type information if required in later PRs. Also see https://vuejs.org/api/sfc-script-setup#defineslots Then also: --- Bumps [vue-tsc](https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc) from 2.1.10 to 2.2.0. - [Release notes](https://github.com/vuejs/language-tools/releases) - [Changelog](https://github.com/vuejs/language-tools/blob/master/CHANGELOG.md) - [Commits](https://github.com/vuejs/language-tools/commits/v2.2.0/packages/tsc) --- updated-dependencies: - dependency-name: vue-tsc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #3336
I got a bit more time to look at #3336 and it looks like Vue folks are moving more and more to macro-based
defineSlotsfor defining slots.Moving everything to use defineSlots worked in most areas and I only had to define the types also for areas where we actually need the type information, otherwise defineSlots is a
Record<string, any>(see https://vuejs-language-tools.vercel.app/features/slots#how-to-handle-indeterminate-slot-types)There 'may' be some other places where it would be advantageous to define our slots as more than
Record<string, any>but for the moment this is enough to unblock the upgrade. We can add any more type information if required in later PRs.Also see https://vuejs.org/api/sfc-script-setup#defineslots