chore(dataplanes): refactor out reusable routes #3406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has no user visible changes, and is purely moving files around in order to make them more reusable. Its a piece of work working towards #3321
All changes are related to making any XDS Config, Stats and Clusters pages resuable across Dataplanes and ZoneIngress/Egress areas.
<RouteView name="prop.routeName" />
in views I'm planning to reuse in several routes.DataPlaneStatsView
etc intoConnectionStatsView
, these will be reusable across DPPs/Zones.ConnectionInbound/OutboundSummaryOverview
back toDataPlaneInbound/OutboundSummaryView
. These files are very specific to DDPs only as they display Rules. These therefore belong in the dataplane module, not connections.props.networking
instead ofprops.dataplaneOverview.networking
.networking
is a property shared between ZoneIngress/Egress and Dataplanes. Currently in this PR we still use the DataPlaneNetworking type for this property, but I would guess I would use a differently named type that covers both types of resources - this will happen in a later PR.