Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dataplanes): refactor out reusable routes #3406

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jan 14, 2025

This PR has no user visible changes, and is purely moving files around in order to make them more reusable. Its a piece of work working towards #3321

All changes are related to making any XDS Config, Stats and Clusters pages resuable across Dataplanes and ZoneIngress/Egress areas.

  • Use <RouteView name="prop.routeName" /> in views I'm planning to reuse in several routes.
  • Uses route prefixing in related route configuration.
  • Moves remaining DataPlaneStatsView etc into ConnectionStatsView, these will be reusable across DPPs/Zones.
  • Moves ConnectionInbound/OutboundSummaryOverview back to DataPlaneInbound/OutboundSummaryView. These files are very specific to DDPs only as they display Rules. These therefore belong in the dataplane module, not connections.
  • Any views that I plan to share are changed to reference props.networking instead of props.dataplaneOverview.networking. networking is a property shared between ZoneIngress/Egress and Dataplanes. Currently in this PR we still use the DataPlaneNetworking type for this property, but I would guess I would use a differently named type that covers both types of resources - this will happen in a later PR.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 2d9245b
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/67868e39ccad460008f59bb5
😎 Deploy Preview https://deploy-preview-3406--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johncowen johncowen force-pushed the chore/refactor-dpp-connections branch from f98041d to 758d900 Compare January 14, 2025 15:38
@johncowen johncowen force-pushed the chore/refactor-dpp-connections branch from 758d900 to 2d9245b Compare January 14, 2025 16:18
@johncowen johncowen marked this pull request as ready for review January 14, 2025 16:22
@johncowen johncowen requested a review from a team as a code owner January 14, 2025 16:22
@johncowen johncowen requested review from schogges and removed request for a team January 14, 2025 16:22
Copy link
Contributor

@schogges schogges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johncowen johncowen merged commit 12a3f2b into kumahq:master Jan 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants