Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint-staged #3401

Merged
merged 2 commits into from
Jan 15, 2025
Merged

chore: lint-staged #3401

merged 2 commits into from
Jan 15, 2025

Conversation

schogges
Copy link
Contributor

This adds lint-staged to all packages and the root to lint staged changes depending on the package (environment).

  1. root: lint lock-file only
  2. kuma-gui: lint styles and scripts only
  3. config: lint scripts only

Apart from lint-staged all the shareable make targets and recipes have been moved to our config/tooling package.

@schogges schogges changed the title Chore/lint staged chore: lint-staged Jan 14, 2025
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 2f1f885
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/678632876247560008ad123a
😎 Deploy Preview https://deploy-preview-3401--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Makefile Show resolved Hide resolved
@schogges schogges marked this pull request as ready for review January 14, 2025 09:54
@schogges schogges requested a review from a team as a code owner January 14, 2025 09:54
@schogges schogges requested review from johncowen and removed request for a team January 14, 2025 09:54
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏 This is all really to coming together now!

Umm I suppose one more note here: As we said yesterday, seeing as the lint-stage config files are so small, if we can figure out how to add those to the package.json files without causing the annoying red config missing error at some point in the future that'd be perfect.

Makefile Show resolved Hide resolved
packages/kuma-gui/Makefile Show resolved Hide resolved
@schogges schogges merged commit 20ae344 into kumahq:master Jan 15, 2025
17 checks passed
@schogges schogges deleted the chore/lint-staged branch January 15, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants