Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dataplane-summary-view): remove tab navigation #3267

Merged

Conversation

schogges
Copy link
Contributor

@schogges schogges commented Dec 6, 2024

In order to improve the user experience by reducing the navigation efforts to show the most important information, we have decided to remove the tab navigation from the dataplane summary view.

As pointed out in #3209

The reason for the separation into tabs was because the summary view could get very crowded already.

I have removed the inbounds section. Both inbounds and outbounds are part of the config, which is now part of the summary view.

Part of #2922

@schogges schogges requested a review from a team as a code owner December 6, 2024 09:49
@schogges schogges requested review from johncowen and removed request for a team December 6, 2024 09:49
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 2c1f012
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/6752c92ae758ee0008df754e
😎 Deploy Preview https://deploy-preview-3267--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@schogges schogges force-pushed the refactor/dataplane-summary-view/remove_tabs branch from c271927 to 2c1f012 Compare December 6, 2024 09:51
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think the GUI is starting to look much better overall now. If I'm just having a glance over my install I can do that without having to leave any list/drawer views at all. I can just click rows and see config without having to dive in and out or more and more GUI pages.

Only if I need to dive deeper into traffic stats or envoy debugging do I need to dive deeper into deeper pages.

The only place left where I can't do this (no drawers yet) is Gateways (both built in a delegated lists) and legacy external services (and there is an argument to say we don't need to bother doing legacy external services)

@schogges schogges merged commit 58bf762 into kumahq:master Dec 6, 2024
16 checks passed
@schogges schogges deleted the refactor/dataplane-summary-view/remove_tabs branch December 6, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants