fix: Use CSS for decoration, fixes CodeQL error with TagList #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
changed the title
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
fix/over-zealous-linter
branch
from
f4e71d7 to
6412646
Compare
|
Sorry I wanted to push a little amend here after reading my own comment from way back when. Been trying to get internet so missed the approval 😅 . I'm sure the addition is fine but let me know if not, otherwise I'll leave this hanging for a little while and then go ahead and merge |
|
FYI this fixed the security alert, hopefully for good 🤞 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see #1803 (review) (you have to open this thing:)
This should fix an over-zealous CodeQL linting security issue/error by using CSS (a super powerful, declarative and therefore pretty much bug free, "from The Outside" language) instead of Javascript.
I think this should probably be an almost global type of rule (I would like to delete
TagListat some point), and I think it would be a good candidate for something similar toXLayout, probably calledXThemewhich we would primarily use at the root of our application.Finally we won't know for sure if this fixes the issue without merging to master, but I think its a better approach even if it doesn't fix the issue.