fix(dataplanes): Correct Dataplane Inbound cluster tab filter #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
commented
Nov 28, 2024
packages/kuma-gui/src/app/connections/views/ConnectionInboundSummaryClustersView.vue
Show resolved
Hide resolved
johncowen
commented
Nov 28, 2024
packages/kuma-gui/src/app/connections/views/ConnectionOutboundSummaryClustersView.vue
Show resolved
Hide resolved
johncowen
commented
Nov 28, 2024
johncowen
force-pushed
the
fix/inbound-clusters
branch
from
625a4cf to
b7c8327
Compare
johncowen
commented
Nov 28, 2024
schogges
reviewed
Nov 29, 2024
packages/kuma-gui/src/app/connections/views/ConnectionInboundSummaryClustersView.vue
Show resolved
Hide resolved
schogges
approved these changes
Nov 29, 2024
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
fix/inbound-clusters
branch
from
28f752a to
9bdb7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were finding lines for inbounds in the cluster response by using the
kuma.io/servicename. We should just be usinglocalhost_<port>.There are few more semi-related things here which I've also noted inline:
urifor better type checking.