Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msw): inconsistent package version in generated file #3095

Merged

Conversation

schogges
Copy link
Contributor

When running make install from outdated or cleaned node_modules the PACKAGE_VERSION in public/mockedServiceWorker.js gets aligned with the version specified in package.json, which causes a diff.

@schogges schogges requested a review from a team as a code owner October 25, 2024 08:32
@schogges schogges requested review from johncowen and removed request for a team October 25, 2024 08:32
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 4e135e2
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/671b578ea1de5c0008c8c766
😎 Deploy Preview https://deploy-preview-3095--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Yeah this is super unfortunate and happens every single time dependabot does an upgrade unfortunately.

I have a vague plan to tell dependabot to also commit this change when it performs the upgrade, more details here:

#2918

I should make an issue for continuing that work ^ actually

@johncowen
Copy link
Contributor

Added an issue for continuing the dependabot work #3096

@schogges
Copy link
Contributor Author

Added an issue for continuing the dependabot work #3096

Perfect 👍 🙂

@johncowen johncowen merged commit b86204d into kumahq:master Oct 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants