chore(deps): Bump vue from 3.4.38 to 3.5.12 #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
dependabot
bot
requested review from
johncowen
and removed request for
a team
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue-3.5.12
branch
10 times, most recently
from
1b39c72 to
b14f3d8
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue-3.5.12
branch
2 times, most recently
from
b365507 to
8b47a63
Compare
slonka
approved these changes
Oct 25, 2024
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue-3.5.12
branch
8 times, most recently
from
d6f6e61 to
d555547
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue-3.5.12
branch
from
d555547 to
cae8ab2
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue-3.5.12
branch
6 times, most recently
from
4721791 to
641cc50
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue-3.5.12
branch
2 times, most recently
from
8a6300c to
e5bb824
Compare
johncowen
added a commit
that referenced
this pull request
Nov 14, 2024
Ideally we wouldn't have to set srcData to `unknown` here and we'd continue to use `TypeOf<T>` which is the type returned by the src from the `sources.ts` file, whatever that is. Thing is our upgrade to vue 3.5 is breaking in this area (#3062). I was kinda holding off with the hope that it would be sorted upstream, and I wanted to avoid using a `@ts-ignore` in order to upgrade. It's also worth noting that srcError uses the exact same construct, but doesn't cause TS issues, which I think is due to it not using a generic type. Then I had another idea. Seeing as we mostly cast `srcData` back to a `NonNullable<TypeOf<T>>` in most places anyway, and we don't need to refer to it within the component at all, we may as well treat it as `unknown`, which is kinda better than using `@ts-ignore`. If we use `unknown` if you do try to use `srcData` within the component you will have to infer it some other way. I gave this a whirl against #3062 and it seems to work fine 🎉 so I decided to PR it separately so we can then rebase the Vue upgrade and move forwards with that. --- edit: I made one more amend here post approval which was to be more careful with the type we use for the exported `data`, for example in `#loadable` `data` can be `undefined` until the DataLoader has loaded, so we don't want to use `NonNullable` there --------- Signed-off-by: John Cowen <[email protected]>
|
@dependabot rebase |
Bumps [vue](https://github.com/vuejs/core) from 3.4.38 to 3.5.12. - [Release notes](https://github.com/vuejs/core/releases) - [Changelog](https://github.com/vuejs/core/blob/main/CHANGELOG.md) - [Commits](vuejs/core@v3.4.38...v3.5.12) --- updated-dependencies: - dependency-name: vue dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue-3.5.12
branch
from
e5bb824 to
828fb4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps vue from 3.4.38 to 3.5.12.
Release notes
Sourced from vue's releases.
... (truncated)
Changelog
Sourced from vue's changelog.
... (truncated)
Commits
770ea67release: v3.5.12c82b662refactor(reactivity): reduce size of collectionHandlers (#12152)ea943affix(runtime-dom): prevent unnecessary updates in v-model checkbox when value ...d82fa61chore: formatd96883ctest(reactivity): test for verifying no unnecessary calls of reactive array i...1ae545afix(hydration): provide compat fallback for idle callback hydration strategy ...05685a9fix(types): retain union type narrowing with defaults applied (#12108)cde2c06fix(compiler): clone loc toifNode(#12131)4474c11fix(compiler-sfc): use sass modern api if available and avoid deprecation war...9da1ac1fix(runtime-core): fix required prop check false positive for kebab-case edge...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)