Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): adds localStorage setup and teardown step #3030

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

johncowen
Copy link
Contributor

Adds a gherkin step to add values to localStorage:

Given the localStorage
  """
    key:
        this:
           will: end
           up: json
           encoded: true     
  """

The root key will be the localStorage key, and the rest will get JSON stringified and used for the value. So the above will be:

| Key | Value                                                   |
| key | {"this": { will: "end", "up": "json", "encoded": true}} | 

We never use anything but this form of JSON encoding, and we shouldn't ever use anything else either.


I also combined visit.ts here. We used to have this separate for reasons, but we no longer need it to be separate. (ln:103 down is just the contents of the deleted file)

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit c2492df
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/66fc2287f1e57800087e5fd4
😎 Deploy Preview https://deploy-preview-3030--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johncowen johncowen marked this pull request as ready for review October 1, 2024 16:34
@johncowen johncowen requested a review from a team as a code owner October 1, 2024 16:34
@johncowen johncowen self-assigned this Oct 10, 2024
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 Qs

cypress/support/step_definitions/index.ts Show resolved Hide resolved
cypress/support/step_definitions/index.ts Show resolved Hide resolved
@johncowen johncowen merged commit 04713ab into kumahq:master Oct 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants