feat(zones): adds ingress/egress online/total counts to zone listing #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kleinfreund
approved these changes
Oct 16, 2023
lahabana
reviewed
Oct 17, 2023
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
feat/zone-gress-counts
branch
from
12bdbaa to
7104a3e
Compare
Signed-off-by: John Cowen <[email protected]>
|
I made the little naming change here, I'll go ahead and merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds online / total counts in the Zone Listing for the Zone's Ingresses and Egresses.
Using the
page=1&size=100assumption here for the moment, with the knowledge that there are backend API additions coming to support this.Again this one is in semi-draft as I'd like to add tests, but I wanted to get something up as I wanted to ask for any ideas around generalising / reusing the getIngresses/getEgresses functions here. I tried various generic type things, but they all turned out a bit weird / non-worky. Let me know if you have any suggestions, if not we can stick with this if there are no issues with it.
Closes #1608