Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inbound/outbound drawers to Zone Proxy Overviews #3321

Open
johncowen opened this issue Dec 18, 2024 · 0 comments
Open

Add inbound/outbound drawers to Zone Proxy Overviews #3321

johncowen opened this issue Dec 18, 2024 · 0 comments
Assignees
@johncowen
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.10.x

Comments

@johncowen
Copy link
Contributor

Description

Follow up of #2976

When clicking on inbound/outbound cards, we should show similar drawers to what you see when looking at the Dataplane inbound/outbound cards.

Note: If there are any issues when not using MeshService: Exclusive and its easier to just make it not work for older style services, we should just do that. See the following from the above issue:

Let's have this only work when using MeshService: Exclusive .

Then again if its harder for some reason to do this, then don't worry.
@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Dec 18, 2024
@johncowen johncowen mentioned this issue Dec 18, 2024
Closed
@johncowen johncowen added this to the 2.10.x milestone Dec 19, 2024
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 23, 2024
@johncowen johncowen self-assigned this Jan 6, 2025
@johncowen johncowen changed the title Add inbound/outbound drawers to ZoneIngress Overview Add inbound/outbound drawers to Zone Proxy Overviews Jan 6, 2025
@johncowen johncowen mentioned this issue Jan 14, 2025
Merged
johncowen added a commit that referenced this issue Jan 15, 2025
@johncowen
chore(dataplanes): refactor out reusable routes (#3406)
12a3f2b 
This PR has no user visible changes, and is purely moving files around
in order to make them more reusable. Its a piece of work working towards
#3321

All changes are related to making any XDS Config, Stats and Clusters
pages resuable across Dataplanes and ZoneIngress/Egress areas.

- Use `<RouteView name="prop.routeName" />` in views I'm planning to
reuse in several routes.
- Uses route prefixing in related route configuration.
- Moves remaining `DataPlaneStatsView` etc into `ConnectionStatsView`,
these will be reusable across DPPs/Zones.
- Moves `ConnectionInbound/OutboundSummaryOverview` back to
`DataPlaneInbound/OutboundSummaryView`. These files are very specific to
DDPs only as they display Rules. These therefore belong in the dataplane
module, not connections.
- Any views that I plan to share are changed to reference
`props.networking` instead of `props.dataplaneOverview.networking`.
`networking` is a property shared between ZoneIngress/Egress and
Dataplanes. Currently in this PR we still use the DataPlaneNetworking
type for this property, but I would guess I would use a differently
named type that covers both types of resources - this will happen in a
later PR.

Signed-off-by: John Cowen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johncowen johncowen

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.10.x
Development

No branches or pull requests
2 participants
@johncowen @lahabana