Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues with lecture 3 notebook #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: issues with lecture 3 notebook #2

wants to merge 3 commits into from

Conversation

enesgrahovac
Copy link

The gradient descent example didn't match the lecture. The sub-plotting wasn't working either.

@enesgrahovac
fix: issues with lecture 3 notebook
7dc0b50 
The gradient descent example didn't match the lecture. The sub-plotting wasn't working either.
@enesgrahovac
fix: error in pandas dataframe merge
770cb2c
@enesgrahovac
fix: plotting 3D graph in latest Python
323f183
@kuleshov
Copy link
Owner

kuleshov commented Nov 8, 2022 •
edited
Loading

Hey, thank you for making edits here. I have a few comments/requests:

  • Could you please not commit that warning message in the first notebook?
  • I also noticed that the version of python changed in one of the notebooks. We shouldn't commit that change unless we update the entire environment (requiements.txt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enesgrahovac @kuleshov