macho: make input object file descriptors short-lived #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids issue described in ziglang/zig#18827
Incidentally improves time performance:
at the cost of somewhat increased memory pressure: at 1459MB up from 1156MB.
I think this tradeoff is worth it, but happy to hear opinions.
EDIT: measurements taken on Intel MBP running macOS 13.6 with 8-core [email protected] and 32GB RAM.
EDIT2: On M1Pro MBP with 32GB RAM, 1466MB up from 1192MB, while benchmarks are: