Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show download speed with the correct units #316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

show download speed with the correct units #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions autoortho/downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ def _show_progress(self, block_num, block_size, total_size):
MBps = (total_fetched/1048576) / elapsed
cur_activity['pcnt_done'] = pcnt_done
cur_activity['MBps'] = MBps
print(f"\r{pcnt_done:.2f}% {MBps:.2f} MBps", end='')
cur_activity['status'] = f"Downloading {self.dl_url}\n{pcnt_done:.2f}% {MBps:.2f} MBps"
print(f"\r{pcnt_done:.2f}% {MBps:.2f} Mbps", end='')
cur_activity['status'] = f"Downloading {self.dl_url}\n{pcnt_done:.2f}% {MBps:.2f} Mbps"
Comment on lines 230 to +233
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this is confusing. I think the rest of the references should also be updated to reflect this.

Also, I think the lines:

        cur_activity['pcnt_done'] = pcnt_done
        cur_activity['MBps'] = MBps

Can go away if the corresponding lines (350,351) in config_ui.py are removed as well.


def check(self):
log.info(f"Checking {self.name}")
Expand Down