Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonny lidar #19

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Sonny lidar #19

wants to merge 21 commits into from

Conversation

kubilus1
Copy link
Owner

See: #14

jonaseberle and others added 21 commits July 9, 2023 03:52
@jonaseberle
Fix Iceland, Faroe and Svalbard, use Sonny's LiDAR
cedef42 
This fixes many mesh problems by using Sonny's digital terrain models
from https://sonny.4lima.de/ for Europe.

Please consider a donation to Sonny for the great DTM that he is
producing and publishing for free.
@jonaseberle
use partly successful work with fail-fast=false
3fa0622
@jonaseberle
add Spitsbergen/Svalbard to eur_tile_list
d649299 
I haven't noticed it has not been part of the scenery at all. But
there should be no reason not to.
@jonaseberle
move the often failing sha256 step into "build"
286ef0b 
"build" has a retry-config. I hope more .zips will successfully pass
like that.
@jonaseberle
Make .zip.info depend on the .zip
7ef9eaa 
We have many failures in that function.
@jonaseberle
add "compilage" to .gitignore
23a6d2f
@jonaseberle
Use .zip.info as build target
f41c0ae 
Maybe that helps with the errors we have in the next step?
@jonaseberle
cleanup
60d0954
@jonaseberle
Add GITHUB_TOKEN to all workflow steps
b6ea982
@jonaseberle
Support debugging by more concise output
66c674e
@jonaseberle
Support quick retries by deleting Ortho4XP with distclean only
8e964cd 
"clean" removes products, distclean brings mostly everything back to
like a clean git checkout
@jonaseberle
work on output, logic
277c3e0
@jonaseberle
Add "build single .zip" workflow for quicker testing
2856ccd
@jonaseberle
remove make concurrency in runners again
5c2d628 
All Ortho4XPs run on the same dir so mabe we had an issue.
@jonaseberle
Show elevation data when starting
3ad4769
@jonaseberle
fix single tile workflow
192b32a
@jonaseberle
Let Makefile.tiles handle the Orto4XP setup, too
c0b8e57
@jonaseberle
Improve the output, show available elevation data
24a9f2e
@kubilus1
Merge branch 'sonny-lidar' into feat/use-sonny-lidar-dtm
25d677a
@kubilus1
Merge pull request #14 from jonaseberle/feat/use-sonny-lidar-dtm
fef336e 
Add Iceland, Faroe and Svalbard/Spitsbergen, use Sonny's LiDAR
@kubilus1
Sort
bf5cf02
@d41k4n
Copy link

d41k4n commented Aug 9, 2023

I would strongly advise to increase curvature_tol to at least 3.0 in order to limit the final mesh triangle count or otherwise users with mid- to lowrange systems will suffer from significant FPS loss with XP12 (especially when comparing to XP11).

@jonaseberle
Copy link

Thanks @d41k4n.
Do you mean that's a good value just when using Sonny or as a general value as well?

@d41k4n
Copy link

d41k4n commented Aug 16, 2023 •
edited
Loading

Do you mean that's a good value just when using Sonny or as a general value as well?

Probably only with Sonny's DTM. If possible the triangle count should not exceed 3-4m (FYI the default base mesh shipped with XP rarely exceeds 500k even in mountainous regions).

@jonaseberle
Copy link

jonaseberle commented Jan 24, 2024 •
edited
Loading

The suggested change by @d41k4n (curvature_tol) is in my branch but not in this one yet.

sonny-lidar...jonaseberle:autoortho-scenery:feat/use-sonny-lidar-dtm

Unfortunately I cannot collaborate on this branch and the original PR is closed thus does not get updated with new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubilus1 @d41k4n @jonaseberle