Remove Iceland #13
Remove Iceland #13
Conversation
With the current default Ortho4XP configuration, Iceland has zero
elevation.
This removes the tiles from the NA tile list.
Command run:
```bash
for y in {63..66}; do
for x in {-25..-14}; do
tileRegex="$(printf "\\%+03d\\%+04d" "$y" "$x")"
sed -i "/^$tileRegex/d" *_tile_list
done
done
```
Fixes: kubilus1#11
Relates: kubilus1#12
|
Thank for the PR! I see there are some instructions out there to fix the elevation: https://forums.x-plane.org/index.php?/forums/topic/259020-autoortho-streaming-ortho-imagery-for-x-plane-11/&page=31#comment-2575931 Might be worth a try with that to see if it can be fixed. |
|
That involves manually downloading elevation data (in these older threads they recommend the 3" Viewfinder DTM). I thought this as a first step to fix the obvious bug (my thinking is users do rather want vanilla than flat), then later introduce a system for custom elevation data to use where we need it. |
|
Yeah I saw the thing about Sonny's data. I briefly looked into that a couple weeks ago, and I think paused with 'where do I manage that large bin' Absolutely ways to do so, but working on shoestring here. A special 'release' may be an option, but there are limits on sizing with that. Would Sonny's data cover Iceland though, I thought that was just for Europe mainland? |
|
Flat areas in Europe: |
|
A test with your
I am about to add the elevation data download from a peudo-release I've asked Sonny if he would be ok with usage in AutoOrtho. if so we can drop this PR I think. |
|
Looks nice! Yeah, that sounds like the way to go. As for creating a
release, there is a 2GB size limit so likely things will need to be split
up. That's not a big deal though, just a to do.
…On Thu, Jul 6, 2023 at 3:00 PM Jonas Eberle ***@***.***> wrote:
A test with your Makefile.tiles worked without any problems for +64-016
after adding the elevation data:
[image: 20230706_193559]
<https://user-images.githubusercontent.com/1678001/251527847-249be9c5-0687-4943-952d-324ab9806663.jpg>
I am about to add the elevation data download from a peudo-release
v0.0.0-assets to the Makefile.
I've asked Sonny if he would be ok with usage in AutoOrtho.
if so we can drop this PR I think.
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVEDLF2K5SGTMOY4AZTN63XO4DNVANCNFSM6AAAAAA2AH6TXA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Sonny approved of it. I think we can close here and I'll open a new one. |
|
Excellent. Yeah there isn't a ton of room on the runners. This has some info: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources You'll notice how I split up the processing as well: https://github.com/kubilus1/autoortho-scenery/blob/main/Makefile.tiles#L53 So not sure how to align the splitting of this info with the execution. |
With the current default Ortho4XP configuration, Iceland has zero
elevation.
This removes the tiles from the NA tile list.
Command run:
Fixes: #11
Relates: #12