Allows more customisation to audit-scanner #282
Conversation
After using audit-scanner, deployed using Helm chart `kubewarden-controller` 1.6.0-rc2, I've noticed that there are a couple of parameters that are available in `audit-scanner` binary that unfortunately we can't use during the chart installation. This commit tries to improve that.
There was a problem hiding this comment.
Thanks for the PR and looking into audit-scanner :).
I wonder though, it seems that the useful feature here would be to provide all log output in JSON, or an additional endpoint for audit-scanner.
What are you expecting from audit-scanner logs?
Is it obtaining all logs in JSON, to consume somewhere else?
We happily accept feat requests, maybe there's a better way to achieve this result.
So far we have made a conscious decision to format the log output as JSON so it could be consumed later on. But we aren't ensuring all output is JSON formatted, for example if the logLevel is raised from info. I think we should do so before we promise printing JSON to logs. With the proposed .Values.enableJsonReport , users would still need to sanitize the output if debug messages are not JSON.
|
Moving to blocked, waiting for more feedback |
|
Sorry, realized now that you opened kubewarden/audit-scanner#102 for that feature request. Unblocking then! |
|
This PR is blocked by kubewarden/audit-scanner#103. |
- Removes customisation of the CA cert since this is generated by `kubewarden-controller` and there's no way to provide a custom one. - Aligns `--print` flag with kubewarden/audit-scanner#103
|
hallo @flavio and @viccuad 👋 apologies for the delay in my response! I've pushed a new commit (c6096bd) which addresses your comments and aligns with |
Co-authored-by: Víctor Cuadrado Juan <[email protected]> Signed-off-by: Flavio Castelli <[email protected]>
Ensure the same comments are done inside of kubewarden-controller's chart-values.yaml and values.yaml files. Signed-off-by: Flavio Castelli <[email protected]>
|
This has been released as appVersion 1.7.0-rc3. |
Description
After using audit-scanner, deployed using Helm chart
kubewarden-controller1.6.0-rc2, I've noticed that there are a couple of parameters that are available inaudit-scannerbinary that unfortunately we can't use during the chart installation. This commit tries to improve that.Additional Information
Potential improvement
Please let me know if you agree with this change or if this isn't at all aligned with the vision that you have for
audit-scanner. Thank you!