-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update persistent TPM & UEFI page to clarify storageclass requirements #830
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ian Bishop <[email protected]>
Signed-off-by: Ian Bishop <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ianb-mp. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I was unsure if the following statement is still true - can anyone confirm?
|
I think so - https://github.com/kubevirt/kubevirt/blob/effcb5b8e6fc951ec5c85ba47ad1daedc0173d79/pkg/virt-api/webhooks/validating-webhook/admitters/vmsnapshot-admitter.go#L166-L174 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
@akalenyu @victortoso @jean-edouard could someone please review? |
The storage class must support read-write-many (RWX) in filesystem mode (FS). | ||
KubeVirt automatically creates backend storage PVCs for VMs that need it. However, to persist TPM and UEFI state, the admin must first enable the `VMPersistentState` feature gate. | ||
|
||
If [live migration](live_migration.md) is required, then the `vmStateStorageClass` configuration parameter should be set, and must reference a storage class that supports read-write-many (RWX) in filesystem mode (FS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not anymore. In 1.4, RWO FS backend-storage is migratable. vmStateStorageClass
can still be used to manually specify a storage class though, instead of relying on defaults.
- As mentioned above, the backend storage PVC can only be created using a storage class that supports RWX FS. There is ongoing work to support block storage in future versions of KubeVirt. | ||
### Notes: | ||
- If no storage class is specified, the default storage class will be used | ||
- If the storage class has a storage profile that indicates it only supports read-write-once (RWO) then a RWO PVC will be created and the VMI will be marked as non-migratable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Thank you @ianb-mp for this update. It looks good but needs to be reworked a bit to reflect most recent changes. |
What this PR does / why we need it:
Update Persistent TPM and UEFI state to reflect the changes made in kubevirt/kubevirt#11773
Also, small spelling fix: prerequesites -> prerequisites
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: