Missing dra-pci-driver for approve and lgtm

[alicefr]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

[xpivarc]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xpivarc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[victortoso]

Perhaps we should compile a small doc about steps on enabling new repos :)

/lgtm

[alicefr]

Perhaps we should compile a small doc about steps on enabling new repos :)

Actually, there is: https://github.com/kubevirt/project-infra/blob/main/docs/how-to-add-a-new-repository.md

[enp0s3]

@xpivarc @alicefr Hi, this is the default merge method, so there is no need to set it explicitly. Unless I am missing something

[enp0s3]

Relying on this line

[alicefr]

Ok I removed the last commit

[xpivarc]

@enp0s3
Here we are setting the repository, if you keep this set to false than default merge method is not allowed! Please see note from tide kubevirt/dra-pci-driver#1
@alicefr Please make a PR with this change

[enp0s3]

@xpivarc @alicefr My bad. My intent was to remove the explicit false, because IIUC by default its true.

[alicefr]

we probably need to add it explicitly, it was set as default when I removed the option

[enp0s3]

@alicefr This is super strange, I see the kubevirt repo configuration for example:

      kubevirt:
        allow_rebase_merge: false
        allow_squash_merge: false
        default_branch: main
        description: Kubernetes Virtualization API and runtime in order to define and manage virtual machines.
        has_projects: true
        homepage: https://kubevirt.io

It doesn't have allow_merge_commit: true set explicitly, nevertheless AFAIK we do see commits with "merge.." in the content in the main branch

[victortoso]

/lgtm

[kubevirt-bot]

@alicefr: Updated the plugins configmap in namespace kubevirt-prow at cluster default using the following files:

• key plugins.yaml using file github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.