-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubevirt/kubevirt approvers to this repository's OWNERS #297
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Itamar Holder <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CCing all of the current approvers |
/lgtm This really makes sense to move at a faster pace with design proposals. |
/hold What is the justification of kubevirt/kubevirt approvers to gain approval rights in this repository? Instead of increasing 1 core approver group with individuals, why can we not focus on the decentralized approach in order to increase our bandwidth: See #288 cc @lyarwood tl;dr Before simply adding more approvers, let us please fix the process to make this process more scaleable. |
Hey @fabiand! After we move to kubevirt/enhancements, I guess it would still makes sense that k/k approvers will have approval right in this repo, which I assume will mostly revolve around community guidelines. |
Let's focus on #288 and move it forward. Merging this pr is just making us loose our focus. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
+1 to what @iholder101 said. As discussed in the community meeting, this repository lacks active approvers - this can be seen by the number of open pull requests without any activity from reviewer/approver side. |
@fabiand IMHO we should either split #288 into two (as suggested here) to move it forward, or get this in, or think of a different solution. While we're not being able to converge into a solution, the problem gets bigger over time. I think there's a pretty large consensus to get this PR in. I identify at least @dhiller @acardace @aburdenthehand @fossedihelm @alicefr @RamLavi @orelmisan @orenc1 @lyarwood as supporters for this approach, and we've already raised it in the community meeting and there was no pushback. WDYT? |
I don't believe there is consensus for mass addition of approvers, please refer to the lively discussion on https://groups.google.com/g/kubevirt-dev/c/uqN9cPRZAF8 What we need is few strong and active reviewers, such as the newly-nominated @jean-edouard . We need a plan to ensure that the existing approvers are active, and we need commitment to review and participate. /hold |
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
@iholder101: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This repository lacks approvers, and most of the existing approvers aren't very active anymore.
As Kubevirt becomes more popular and active, and more design proposals are being introduced, we need more people to share the burden of reviewing and approving such proposals. This is especially important since #251 had landed.
Release note: