Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centos, rhel: Fix DPDK preference requirements #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

These preferences actually require at least 4 vCPUs through their use of a SocketsCoresThreads spread ratio of 1:4:2 [1].

Functional tests asserting that we can create VMs using these preferences and instance types providing the required amount of resource are also tweaked to use a smaller size.

[1] https://kubevirt.io/user-guide/user_workloads/instancetypes/#spreadoptions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

These preferences actually require at least 4 vCPUs through their use of
a SocketsCoresThreads spread ratio of 1:4:2 [1].

Functional tests asserting that we can create VMs using these
preferences and instance types providing the required amount of resource
are also tweaked to use a smaller size.

[1] https://kubevirt.io/user-guide/user_workloads/instancetypes/#spreadoptions

Signed-off-by: Lee Yarwood <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 21, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lyarwood. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Contributor

@lyarwood: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-common-instancetypes-kubevirt-functest d6e74a6 link true /test pull-common-instancetypes-kubevirt-functest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lyarwood
Copy link
Member Author

lyarwood commented Oct 21, 2024

/hold

Ah actually the ratio is the issue here, 1*4*2 is 8 vCPUs, we should really be using a ratio of 2 for 1*2*2 4 vCPUs

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants