events: Remove duplicated 'Available' events (#1922)

CNAO is emitting config 'Availabe' event after each reconcile even when nothing changes, this add noise to users. This change emits the event only if Available changes from false to true. Signed-off-by: Enrique Llorente <[email protected]>
kubevirt · Oct 25, 2024 · fca381a · fca381a
1 parent 608031a
commit fca381a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/controller/statusmanager/status_manager.go b/pkg/controller/statusmanager/status_manager.go
@@ -159,7 +159,11 @@ func (status *StatusManager) set(reachedAvailableLevel bool, conditions ...condi
 		)
 	} else if reachedAvailableLevel {
 		// If successfully deployed all components and is not failing on anything, mark as Available
-		status.eventEmitter.EmitAvailableForConfig()
+		if conditionsv1.IsStatusConditionFalse(config.Status.Conditions, conditionsv1.ConditionAvailable) {
+			// Emit event only if conditions changes from false to true to
+			// so we don't duplicate events
+			status.eventEmitter.EmitAvailableForConfig()
+		}
 		conditionsv1.SetStatusConditionNoHeartbeat(&config.Status.Conditions,
 			conditionsv1.Condition{
 				Type:   conditionsv1.ConditionAvailable,