Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-431] Disable create for reader only users #639

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 31, 2023

Ref:
Jira: https://issues.redhat.com/browse/MTV-431
GH: #631

[ Note: this PR fix a type in the edit permissions too, group: apiGroup instead of group apiVersion ]

Issue:
We currently allow users without permissions to try and create Providers Plans and Mappings from the list view

Fix:
Check for permissions and disable actions that requires patch or delete permissions when users are not allowed to do this actions

Screenshots:
Before:
RBAC-plans

RBAC-providers

RBAC-mappings

After:
RBAC-mappings

RBAC-plans

RBAC-providers

@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jul 31, 2023
@yaacov yaacov added this to the 2.5.0 milestone Jul 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yaacov yaacov changed the title Disable create for reader only users [MTV-431] Disable create for reader only users Jul 31, 2023
@yaacov yaacov merged commit 379b786 into kubev2v:main Jul 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant