[MTV-431] Disable delete for reader users #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yaacov <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
4 tasks
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Sep 12, 2023
This fixes a bug of Mappings actions dropdown menu options that are always disabled. As a followup for kubev2v#636, we now need to re-render the Storage/Network Mappings actions dropdown menu once the user's permissions are changed. The root cause is that since the user's access permissions are set to false at loading till it is synced, the menu options are disabled at start and need to be re-rendered once the data is synced. Signed-off-by: Sharon Gratch <[email protected]>
rszwajko
pushed a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Sep 15, 2023
This fixes a bug of Mappings actions dropdown menu options that are always disabled. As a followup for kubev2v#636, we now need to re-render the Storage/Network Mappings actions dropdown menu once the user's permissions are changed. The root cause is that since the user's access permissions are set to false at loading till it is synced, the menu options are disabled at start and need to be re-rendered once the data is synced. Signed-off-by: Sharon Gratch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
Jira: https://issues.redhat.com/browse/MTV-431
GH: #631
Issue:
We currently allow users without permissions to try and edit or delete Plans and Mappings from the list view
Fix:
Check for permissions and disable actions that requires patch or delete permissions when users are not allowed to do this actions
Screenshots:
Before:
After:
