Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract Execution Worker #5923

Merged
merged 77 commits into from
Oct 17, 2024
Merged

feat: extract Execution Worker #5923

merged 77 commits into from
Oct 17, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Oct 11, 2024 •
edited
Loading

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@rangoo94
chore: delete unused
b7f01e5
@rangoo94
chore: delete subscription checker from API instance
81901f9
@rangoo94
fixup
912b601
@rangoo94
fix: simplify applying the global template
e282a40
@rangoo94
chore: extract cloud/storage machines in Test Workflow executor
94598d8
@rangoo94
chore: rename id variable to executionId
b0b4b64
@rangoo94
chore: extract workflow machine in Test Workflow executor
ca4c2b8
@rangoo94
chore: use the earliest timestamp for execution schedulement
e5fc38d
@rangoo94
chore: extract resource machine
398f32d
@rangoo94
fixup workflow machine
aea1c4c
@rangoo94
chore: make schedule time UTC
fe3c528
@rangoo94
chore: extract helper for validating the TestWorkflow
fa701a1
@rangoo94
chore: serialize propagated execution tags as JSON
4e6c236
@rangoo94
chore: a bit of grouping
23f2ffa
@rangoo94
chore: clean namespace from resolved workflow too
b0491b2
@rangoo94
chore: detach secret's batch from namespace
7c69892
@rangoo94
fixup avoid deleting namespace
a12a937
@rangoo94
chore: add some comments
2dd81e0
@rangoo94
chore: move configuration resolution higher
f72077b
@rangoo94
fix: determine execution namespace after the templates are applied
19f961f
@rangoo94
fixup
5d41c09
@rangoo94
chore: avoid unnecessary variables
b1fe57a
@rangoo94
chore: avoid pre-validating the workflow
f63e0d9
@rangoo94
chore: move place where the resolved workflow is preserved
3189a77
@rangoo94
chore: move place where the default service account is applied
4ed6198
@rangoo94
feat: always create TestWorkflowExecution before deployment
502c165
@rangoo94
chore: decouple a bit creating TestWorkflow execution
5338c7c
@rangoo94
chore: split a bit logic of updating execution
c5ea122
@rangoo94
chore: organize better the internal configuration passed to Test Work…
f45fbe3 
…flow execution

- use single annotation instead of multiple duplicated environment variables
- group the variables nicely
- handle that recursively
@rangoo94
chore: reorder configs
dad65a4
@rangoo94 rangoo94 force-pushed the dawid/feat/extract-execution-engine branch from a2b2907 to 47a41d6 Compare October 14, 2024 09:06
@rangoo94
fix: list resources correctly in Execution Worker
5f6e6bd
@rangoo94
fix: lint
32d8672
@rangoo94
fix: lint
26c03f4
@rangoo94
fixup unit tests
20a89fb
@rangoo94
chore: delete some unused code
6eb7f1d
@rangoo94
chore: delete unused machine resolution
c46c4ec
@rangoo94
fix: use pro context for determining organization/environment ID in T…
bc8e938 
…est Workflow executor
@rangoo94
fix: handle better unique execution names
30992cf
@rangoo94
fix: unit/integration tests
1a42364
@rangoo94
chore: delete unused code
6d18e7f
@rangoo94
chore: avoid unnecessary fallback
898da90
@rangoo94
chore: clean up worker interface a bit
f136ad0
@rangoo94
chore: clean up worker interface a bit
f314022
@rangoo94
chore: separate functions for creating a service and execution
b90abf8
@rangoo94
chore: unify Execute() and Service() a bit
3795b4d
@rangoo94
chore: reorder a bit
bf494f6
@rangoo94
chore: reorder a bit
ce27ea7
@rangoo94
feat: persist scheduledAt in the Job/Pod annotations
7620e1c
@rangoo94
fixup unit tests
4779824
@rangoo94
fix: CLI for initialization error watch
29889dc
@rangoo94 rangoo94 marked this pull request as ready for review October 14, 2024 15:44
@rangoo94 rangoo94 requested a review from a team as a code owner October 14, 2024 15:44
@rangoo94 rangoo94 merged commit 0b8bae9 into main Oct 17, 2024
7 checks passed
@rangoo94 rangoo94 deleted the dawid/feat/extract-execution-engine branch October 17, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin