fix: http/2 stream leaks #5775
Open
fix: http/2 stream leaks #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
When response bodies are not properly an HTTP/2 client can leak streams which can eventually lead to a failure case (i.e.
stream error: stream ID 1; INTERNAL_ERROR) related HTTP/2 flow-control. Here is a more thorough description of the issue: googleapis/google-cloud-go#7440 (comment)This fixes cases where the response body for an HTTP request was not closed, and also refactors some of the code to make it easier to see when the stream has been closed.
In a couple of cases, it relied on the
SendStreammethod from thefiberpackage to close the stream, but I could not find anywhere in their docs or code base where it actually closed the stream.Checklist (choose whats happened)
Breaking changes
Changes
Fixes