fix: add transactions for numbers #5729
Conversation
Signed-off-by: Vladislav Sukhin <[email protected]>
Signed-off-by: Vladislav Sukhin <[email protected]>
Signed-off-by: Vladislav Sukhin <[email protected]>
Signed-off-by: Vladislav Sukhin <[email protected]>
| } | ||
| defer session.EndSession(ctx) | ||
|
|
||
| _, err = session.WithTransaction(ctx, func(sessCtx mongo.SessionContext) (interface{}, error) { |
There was a problem hiding this comment.
Either that should be an atomic MongoDB query, or better to go with an external lock (NATS or Mongo?) - mixing the Golang logic with MongoDB queries will lead to broken results anyway; in best case, for concurrent transactions, it will increment sequence correctly, but will try with the duplicated execution name
There was a problem hiding this comment.
yes, transactions are supported only for replicaset and will not help, external lock with Mongo might work
There was a problem hiding this comment.
actualy, distributed lock is also not a silver bullet, if connection fails before the lock is removed, it will be necessary to wait till it is expired. so instead of simply rerunning the test and have a missed number, user will need to wait sometime and not sure, it's a better option for him. I would rather discuss it first, if we need it or not
Pull request description
Checklist (choose whats happened)
Breaking changes
Changes
Fixes