feat(TKC-1580): prepare Init Process for TestWorkflow containers #5090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rangoo94
requested review from
exu,
nicufk,
vsukhin,
vLia,
povilasv and
dejanzele
as code owners
✅ Deploy Preview for testkube-docs-preview canceled.
|
vsukhin
reviewed
Feb 29, 2024
vsukhin
reviewed
Feb 29, 2024
vsukhin
approved these changes
Feb 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5090 +/- ##
===========================================
- Coverage 30.33% 26.36% -3.97%
===========================================
Files 314 315 +1
Lines 28149 28381 +232
===========================================
- Hits 8538 7484 -1054
- Misses 18781 20257 +1476
+ Partials 830 640 -190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rangoo94
deleted the
dawid/feat/TKC-1580-create-init-process-image-for-testworkflows
branch
rangoo94
added a commit
that referenced
this pull request
Mar 14, 2024
* feat(TKC-1465): add helpers to immediately evaluate Template/Expression * feat(TKC-1465): add option to force simplifying templates in unknown structs * fix(TKC-1465): template evaluation typo * fix(TKC-1465): simplifying private properties in structs * fix(TKC-1465): deep simplify structs * fix(TKC-1465): EvalExpression typo * fix(TKC-1465): Negation precedence * fix(TKC-1465): add negative number test * feat(TKC-1465): predict logical operations paths * feat(TKC-1580): prepare initial Init Process for TestWorkflow containers * feat(TKC-1580): distinguish hints of outputs in TestWorkflow containers * chore(TKC-1580): delete unused code * chore(TKC-1580): extract commons for critical errors in init process * feat(TKC-1465): add Escape helper * feat(TKC-1580): make conditions order irrelevant * fix(TKC-1580): compute init status with execution status too * fix(TKC-1580): compute conditions correctly * fix: image inspector with ConfigMap * feat(TKC-1465): add option to finalize structs with expression language
rangoo94
added a commit
that referenced
this pull request
Mar 14, 2024
* feat(TKC-1465): add helpers to immediately evaluate Template/Expression * feat(TKC-1465): add option to force simplifying templates in unknown structs * fix(TKC-1465): template evaluation typo * fix(TKC-1465): simplifying private properties in structs * fix(TKC-1465): deep simplify structs * fix(TKC-1465): EvalExpression typo * fix(TKC-1465): Negation precedence * fix(TKC-1465): add negative number test * feat(TKC-1465): predict logical operations paths * feat(TKC-1580): prepare initial Init Process for TestWorkflow containers * feat(TKC-1580): distinguish hints of outputs in TestWorkflow containers * chore(TKC-1580): delete unused code * chore(TKC-1580): extract commons for critical errors in init process * feat(TKC-1465): add Escape helper * feat(TKC-1580): make conditions order irrelevant * fix(TKC-1580): compute init status with execution status too * fix(TKC-1580): compute conditions correctly * fix: image inspector with ConfigMap * feat(TKC-1465): add option to finalize structs with expression language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Prepare Init Process that will wrap all TestWorkflows operations in the containers. Additionally, it includes some fixes and improvements to the Expressions Engine (force simplifying unknown structs, better boolean prediction).
It supports:
file("/data/some/path")), reading shared dataIn the future, we need to support:
Checklist (choose whats happened)