fix: panic on empty bool env (#5018)

* fix: panic on empty bool env * fix: test
kubeshop · Feb 28, 2024 · 7f2c566 · 7f2c566
1 parent 36ef09c
commit 7f2c566
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/executor/common.go b/pkg/executor/common.go
@@ -45,7 +45,7 @@ const (
 var RunnerEnvVars = []corev1.EnvVar{
  {
  Name: "DEBUG",
- Value: os.Getenv("DEBUG"),
+ Value: getOr("DEBUG", "false"),
  },
  {
  Name: "RUNNER_ENDPOINT",

diff --git a/pkg/executor/containerexecutor/containerexecutor_test.go b/pkg/executor/containerexecutor/containerexecutor_test.go
@@ -130,7 +130,7 @@ func TestNewExecutorJobSpecWithArgs(t *testing.T) {
  assert.NotNil(t, spec)
 
  wantEnvs := []corev1.EnvVar{
- {Name: "DEBUG", Value: ""},
+ {Name: "DEBUG", Value: "false"},
  {Name: "RUNNER_ENDPOINT", Value: ""},
  {Name: "RUNNER_ACCESSKEYID", Value: ""},
  {Name: "RUNNER_SECRETACCESSKEY", Value: ""},