SANDBOX-677 use go-version-file #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
sbryzak,
mfrancisc,
drpaneas,
metlos and
fbm3307
as code owners
alexeykazakov
approved these changes
Jul 16, 2024
fbm3307
reviewed
Jul 16, 2024
| @@ -19,16 +19,16 @@ jobs: | |||
|
|
|||
There was a problem hiding this comment.
Can you remove GO_VERSION: from env: too? at line 11 , it is not used anymore i guess
There was a problem hiding this comment.
whoops, good eye, I somehow missed this - thought i had removed it.
removed in 6950e0f
MatousJobanek
approved these changes
Jul 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 43 43
Lines 2372 2372
=======================================
Hits 1590 1590
Misses 596 596
Partials 186 186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses go-version-file instead of go-version. One less place to change when making updates.
Changes order in github action to first checkout code and then install go.
related PRs:
codeready-toolchain/api#434
codeready-toolchain/toolchain-common#415
codeready-toolchain/member-operator#584
codeready-toolchain/registration-service#445
codeready-toolchain/host-operator#1060
codeready-toolchain/toolchain-e2e#1014