Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: force user/identity manifest generation #39

Merged
merged 4 commits into from
May 31, 2024

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented May 27, 2024

new allClusters boolan field in the YAML config files
to force the generation of the user and identity manifests
for users, even if they don't have any permissions.

This happens in case of OCM accounts who need to be
provisioned on all clusters, but whose association with RBAC
groups is managed by OCM.

Signed-off-by: Xavier Coulon [email protected]

new `allClusters` boolan field in the YAML config files
to force the generation of the user and identity manifests
for users, even if they don't have any permissions.

This happens in case of OCM accounts who need to be
provisioned on all clusters, but whose association with RBAC
groups is managed by OCM.

Signed-off-by: Xavier Coulon <[email protected]>
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great job 👍

pkg/assets/assets_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.40%. Comparing base (6abef3e) to head (ec9b2df).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   66.44%   66.40%   -0.05%     
==========================================
  Files          41       41              
  Lines        2265     2268       +3     
==========================================
+ Hits         1505     1506       +1     
- Misses        582      583       +1     
- Partials      178      179       +1     
Files Coverage Δ
pkg/cmd/generate/permissions.go 79.84% <100.00%> (ø)
pkg/cmd/generate/cluster.go 76.92% <40.00%> (-5.69%) ⬇️

@xcoulon xcoulon merged commit 6cabf40 into kubesaw:master May 31, 2024
6 of 7 checks passed
@xcoulon xcoulon deleted the generate_admin_manifests branch May 31, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants