Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag to set ServiceAccount token expiry #30

Merged
merged 4 commits into from
Apr 17, 2024
Merged

flag to set ServiceAccount token expiry #30

merged 4 commits into from
Apr 17, 2024

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Apr 17, 2024 •
edited
Loading

xcoulon
xcoulon approved these changes Apr 17, 2024
View reviewed changes
pkg/cmd/generate/cli_configs.go Outdated Show resolved Hide resolved
mfrancisc
mfrancisc approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Super fast ⚡

fbm3307
fbm3307 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

filariow
filariow reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just some questions and nits

pkg/cmd/generate/cli_configs.go Outdated Show resolved Hide resolved
pkg/cmd/generate/cli_configs.go Outdated Show resolved Hide resolved
pkg/cmd/generate/cli_configs.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #30 (4a60955) into master (a0b137d) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   65.77%   65.76%   -0.02%     
==========================================
  Files          40       40              
  Lines        2028     2030       +2     
==========================================
+ Hits         1334     1335       +1     
- Misses        536      537       +1     
  Partials      158      158
Files Coverage Δ
pkg/cmd/generate/cli_configs.go 73.28% <88.88%> (-0.33%) ⬇️

@MatousJobanek MatousJobanek merged commit 11f8a31 into kubesaw:master Apr 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filariow filariow filariow left review comments

@fbm3307 fbm3307 fbm3307 approved these changes

@mfrancisc mfrancisc mfrancisc approved these changes

@xcoulon xcoulon xcoulon approved these changes

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

@drpaneas drpaneas Awaiting requested review from drpaneas drpaneas is a code owner

@metlos metlos Awaiting requested review from metlos metlos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MatousJobanek @xcoulon @mfrancisc @fbm3307 @filariow