Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all EnvVar values in sig-scalability-presets.yaml strings #33532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make all EnvVar values in sig-scalability-presets.yaml strings #33532

wants to merge 1 commit into from
+24 −24

Commits on Sep 25, 2024

  1. Make all sig-scalability preset EnvVars strings 

    In the `Preset` stuct environment variables are stored in a slice of
`v1.EnvVar`. Which, in turn assumes the value is a string. We should be
consistent and make the values in the sig-scalability-presets.yaml
strings too.
    @hbostan
    hbostan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    788f08b View commit details
    Browse the repository at this point in the history