Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPZ: use regex to run e2e only on relevant files #29123

Merged
merged 1 commit into from
Mar 24, 2023
Merged

CAPZ: use regex to run e2e only on relevant files #29123

merged 1 commit into from
Mar 24, 2023

Conversation

CecileRobertMichon
Copy link
Member

@CecileRobertMichon CecileRobertMichon commented Mar 23, 2023 •
edited
Loading

Fixes kubernetes-sigs/cluster-api-provider-azure#3248

inspired from

test-infra/config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

Line 131 in 7df7ec4

run_if_changed: '^((api|bootstrap|cmd|config|controllers|controlplane|errors|exp|feature|hack|internal|scripts|test|util|webhooks|version)/|main\.go|go\.mod|go\.sum|Dockerfile|Makefile)'

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs area/provider/azure Issues or PRs related to azure provider labels Mar 23, 2023
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
mboersma
mboersma reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This skip_if_only_changed regex looks good to me: I'm trying it out in a regex tester and it matches everything I thought of.

@CecileRobertMichon
Copy link
Member Author

squashed! Let's try it out in the wild?

@CecileRobertMichon
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@CecileRobertMichon
Copy link
Member Author

/retest

?

mboersma
mboersma reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@CecileRobertMichon
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5a27620 into kubernetes:master Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
  • key cluster-api-provider-azure-presubmits-release-v1beta1.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1beta1.yaml

In response to this:

Fixes kubernetes-sigs/cluster-api-provider-azure#3248

inspired from

test-infra/config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

Line 131 in 7df7ec4

run_if_changed: '^((api|bootstrap|cmd|config|controllers|controlplane|errors|exp|feature|hack|internal|scripts|test|util|webhooks|version)/|main\.go|go\.mod|go\.sum|Dockerfile|Makefile)'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma mentioned this pull request Mar 27, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nawazkh nawazkh nawazkh left review comments

@mboersma mboersma mboersma left review comments

@Jont828 Jont828 Awaiting requested review from Jont828

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude E2E tests for documentation-only PRs
4 participants
@CecileRobertMichon @k8s-ci-robot @mboersma @nawazkh