Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid parent process if no log redirection is used #3624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid parent process if no log redirection is used #3624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion images/build/go-runner/go-runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ func configureAndRun() error {
var (
outputStream io.Writer = os.Stdout
errStream io.Writer = os.Stderr
err error
)

args := flag.Args()
Expand Down Expand Up @@ -79,7 +80,11 @@ func configureAndRun() error {
cmd.Stderr = errStream

log.Printf("Running command:\n%v", cmdInfo(cmd))
err := cmd.Start()
if cmd.Stdout == os.Stdout && cmd.Stderr == os.Stderr {
err = syscall.Exec(cmd.Path, cmd.Args, syscall.Environ())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this feels like a potentially breaking change. Shall we make it an optional feature or such?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but the idea was to automatically/intelligently save systems resources by avoiding the parent process (go-runner) if not needed. What do you think about an opt-out argument/flag?

} else {
err = cmd.Start()
}
if err != nil {
return fmt.Errorf("starting command: %w", err)
}
Expand Down