feat: Add errcheck linter with golangci-lint

[kushthedude]

Refers #1244

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @kushthedude!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kushthedude. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kushthedude]

/cla signed

[kushthedude]

/assign @shyamjvs
/cc @wojtek-t

[kushthedude]

Hey @wojtek-t, I see that the bash script to run golangcilint & lib/gopkg to find modules do not run on macOS due to

find: -printf: unknown primary or operator

should I also push updated script on the basis of OS_ENV ?

[wojtek-t]

/ok-to-test

[wojtek-t]

There are two more issues:
benchmarks/netperf/launch.go:367:3: Println call has possible formatting directive %v

--- FAIL: TestLogging (0.00s)
--- FAIL: TestLogging/print_5_warnings (0.00s)
api_responsiveness_prometheus_test.go:578: cant gather config top latency metric: there should be no high-latency requests, but: [got: &{Resource:r1 Subresource: Verb:POST Scope: Latency:perc50: 0s, perc90: 0s, perc99: 1.2s Count:0 SlowCount:0}; expected perc99 <= 1s]
--- FAIL: TestLogging/print_all_violations (0.00s)
api_responsiveness_prometheus_test.go:578: cant gather config top latency metric: there should be no high-latency requests, but: [got: &{Resource:r2 Subresource: Verb:POST Scope: Latency:perc50: 0s, perc90: 0s, perc99: 1.9s Count:0 SlowCount:0}; expected perc99 <= 1s got: &{Resource:r3 Subresource: Verb:POST Scope: Latency:perc50: 0s, perc90: 0s, perc99: 1.8s Count:0 SlowCount:0}; expected perc99 <= 1s got: &{Resource:r4 Subresource: Verb:POST Scope: Latency:perc50: 0s, perc90: 0s, perc99: 1.7s Count:0 SlowCount:0}; expected perc99 <= 1s got: &{Resource:r5 Subresource: Verb:POST Scope: Latency:perc50: 0s, perc90: 0s, perc99: 1.6s Count:0 SlowCount:0}; expected perc99 <= 1s got: &{Resource:r6 Subresource: Verb:POST Scope: Latency:perc50: 0s, perc90: 0s, perc99: 1.5s Count:0 SlowCount:0}; expected perc99 <= 1s got: &{Resource:r1 Subresource: Verb:POST Scope: Latency:perc50: 0s, perc90: 0s, perc99: 1.2s Count:0 SlowCount:0}; expected perc99 <= 1s]

Modulo fixing those it looks fine

[kushthedude]

@wojtek-t I fixed the first issue, about the second there is a latency increase of 1.2 sec which can be due to the test parameter I added hence due to which test is failing, how should I go about this?

[wojtek-t]

about the second there is a latency increase of 1.2 sec which can be due to the test parameter I added hence due to which test is failing, how should I go about this?

It's not about latency increase - the data are faked in this test and this 1.2s is hardcoded - see line 465.

The real issue is different something is logged differently - you need to take a look into what was logger previously and what is logged now (and why this is different).

[kushthedude]

@wojtek-t Please review, I have just logged that error rather than failing the test at gatherer function.

[wojtek-t]

@kushthedude - please fix the compile errors and then LGTM

[kushthedude]

@kushthedude - please fix the compile errors and then LGTM

should be fixed now !

Edit: @wojtek-t Fixed!

[wojtek-t]

Thanks a lot for pushing this!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kushthedude, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kushthedude]

Thanks @wojtek-t for bearing with me in this PR 😄