-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cilium: remove appArmorProfile for k8s<v1.30.0 #19888
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ComradeProgrammer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
184ebc9
to
7f731c5
Compare
/ok-to-test |
@ComradeProgrammer thanks for the PR :) plz check the lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make sure the PR mentions cillim, so in the changelog users know it only affects the cillim
cilium: remove appArmorProfile for k8s<v1.30.0
This comment has been minimized.
This comment has been minimized.
7f731c5
to
fca5ebd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fca5ebd
to
6e61e68
Compare
kvm2 driver with docker runtime
Times for minikube start: 45.3s 46.7s 49.5s 48.6s 47.7s Times for minikube ingress: 15.0s 14.9s 14.4s 19.0s 14.9s docker driver with docker runtime
Times for minikube (PR 19888) start: 20.5s 21.2s 27.1s 23.3s 23.0s Times for minikube ingress: 12.3s 12.3s 12.3s 13.8s 12.8s docker driver with containerd runtime
Times for minikube (PR 19888) start: 20.0s 19.0s 22.1s 20.1s 19.7s Times for minikube ingress: 23.7s 38.7s 39.3s 39.2s 38.7s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
FIX #19683
cilium: remove spec.template.spec.securityContext.appArmorProfile field when k8s version is smaller than 1.30.0
Before:
After: