Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TestMachineType failing on macOS #19726

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix TestMachineType failing on macOS #19726

merged 1 commit into from
Sep 30, 2024

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Sep 28, 2024

adding VFKit type to the table test

before

go test ./pkg/minikube/driver -run TestMachineType -v
=== RUN   TestMachineType
    driver_test.go:83: mismatched machine type for driver vfkit: want =  got = VM
--- FAIL: TestMachineType (0.00s)
FAIL
FAIL	k8s.io/minikube/pkg/minikube/driver	0.761s
FAIL

after

go test ./pkg/minikube/driver -run TestMachineType -v
=== RUN   TestMachineType
--- PASS: TestMachineType (0.00s)
PASS
ok  	k8s.io/minikube/pkg/minikube/driver	0.759s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2024
@prezha prezha self-assigned this Sep 28, 2024
@spowelljr spowelljr merged commit 97892cb into kubernetes:master Sep 30, 2024
27 of 29 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

Assignees

@prezha prezha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prezha @k8s-ci-robot @spowelljr