Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Move bulk of GCP-Auth addon test into subtest #19716

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

spowelljr
Copy link
Member

Simply moving all of the GCP-Auth addon test that's not already in a subtest into a sub test so failures are properly displayed in gopogh, part of #19714.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2024
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 27, 2024
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19716) |
+----------------+----------+---------------------+
| minikube start | 48.4s    | 49.2s               |
| enable ingress | 15.1s    | 15.3s               |
+----------------+----------+---------------------+

Times for minikube start: 47.1s 50.1s 47.5s 47.4s 49.8s
Times for minikube (PR 19716) start: 46.3s 50.2s 47.9s 52.6s 48.9s

Times for minikube ingress: 15.5s 14.5s 15.5s 14.5s 15.5s
Times for minikube (PR 19716) ingress: 15.0s 15.5s 15.0s 15.0s 16.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19716) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 21.9s               |
| enable ingress | 12.8s    | 13.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 13.3s 13.3s 12.8s 13.3s 11.3s
Times for minikube (PR 19716) ingress: 12.3s 13.3s 13.3s 13.3s 13.8s

Times for minikube start: 20.8s 23.4s 23.3s 20.8s 23.7s
Times for minikube (PR 19716) start: 20.9s 21.0s 20.3s 23.4s 23.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19716) |
+----------------+----------+---------------------+
| minikube start | 21.3s    | 21.8s               |
| enable ingress | 26.4s    | 24.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 19716) start: 20.9s 23.0s 22.0s 22.7s 20.4s
Times for minikube start: 22.6s 22.6s 20.1s 20.4s 20.9s

Times for minikube ingress: 23.8s 22.8s 39.8s 22.8s 22.8s
Times for minikube (PR 19716) ingress: 23.8s 24.3s 23.3s 23.8s 28.8s

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux (1 failed) TestAddons/serial/GCPAuth/PullSecret(gopogh) Unknown
Docker_Linux_crio (3 failed) TestAddons/serial/GCPAuth/PullSecret(gopogh) Unknown
KVM_Linux (1 failed) TestAddons/serial/GCPAuth/PullSecret(gopogh) Unknown
none_Linux (1 failed) TestAddons/serial/GCPAuth/PullSecret(gopogh) Unknown
Docker_Linux_crio_arm64 (3 failed) TestAddons/serial/GCPAuth/PullSecret(gopogh) Unknown
Docker_Linux_docker_arm64 (1 failed) TestAddons/serial/GCPAuth/PullSecret(gopogh) Unknown

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Oct 2, 2024

/lgtm

@medyagh medyagh merged commit 746051d into kubernetes:master Oct 2, 2024
22 of 37 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the moveToSubtest branch October 2, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants