Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Add defer to disable addon to start of each addon test #19715

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Sep 27, 2024

#19714

Add defer to disable addon to start of each addon test. In relation to #19714, this will prevent GCP-Auth addon mock issue from affecting the registry test.

This PR should fix the registry test for all environments.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 28, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19715) |
+----------------+----------+---------------------+
| minikube start | 50.4s    | 50.5s               |
| enable ingress | 16.7s    | 15.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 17.1s 16.1s 15.6s 19.1s 15.5s
Times for minikube (PR 19715) ingress: 15.6s 15.0s 15.5s 15.6s 16.1s

Times for minikube start: 49.6s 50.3s 51.2s 51.6s 49.4s
Times for minikube (PR 19715) start: 49.4s 49.5s 50.3s 51.9s 51.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19715) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 22.7s               |
| enable ingress | 13.0s    | 12.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 12.3s 12.8s 13.3s 13.9s 12.8s
Times for minikube (PR 19715) ingress: 13.8s 12.8s 10.8s 12.3s 12.8s

Times for minikube start: 23.9s 24.2s 20.8s 23.4s 24.3s
Times for minikube (PR 19715) start: 23.3s 20.7s 23.5s 21.4s 24.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19715) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 21.4s               |
| enable ingress | 29.3s    | 24.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 22.3s 23.3s 23.0s 22.6s
Times for minikube (PR 19715) start: 22.5s 19.2s 22.4s 20.0s 22.8s

Times for minikube ingress: 22.8s 22.8s 22.8s 38.8s 39.3s
Times for minikube (PR 19715) ingress: 29.3s 22.8s 22.8s 23.3s 22.8s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
KVM_Linux (1 failed) TestMultiNode/serial/RestartMultiNode(gopogh) 0.60% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit b623c21 into kubernetes:master Oct 1, 2024
23 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants