Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicbase/ISO: Update cri-dockerd from v0.3.3 to v0.3.9 #17055

Closed
wants to merge 1 commit into from
Closed

Kicbase/ISO: Update cri-dockerd from v0.3.3 to v0.3.9 #17055

wants to merge 1 commit into from

Conversation

minikube-bot
Copy link
Collaborator

The cri-dockerd project released a new version

This PR was auto-generated by make update-cri-dockerd-version using update-cri-dockerd-version.yml CI Workflow.

A minikube maintainer needs to checkout this PR, run make build-and-upload-cri-dockerd-binaries, and then comment ok-to-build-image.

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2023
@medyagh
Copy link
Member

medyagh commented Aug 14, 2023

ok-to-build-iso

@medyagh
Copy link
Member

medyagh commented Aug 14, 2023

/ok-to-build-image

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@medyagh
Copy link
Member

medyagh commented Aug 30, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2023
@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2023
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot minikube-bot changed the title Kicbase/ISO: Update cri-dockerd from v0.3.3 to v0.3.8 Kicbase/ISO: Update cri-dockerd from v0.3.3 to v0.3.9 Jan 8, 2024
@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 17055) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 51.6s    | 74.2s ⚠️             |
| enable ingress    | 27.5s    | 27.2s               |
+-------------------+----------+---------------------+

Times for minikube ingress: 27.5s 28.1s 27.2s 27.6s 27.1s
Times for minikube (PR 17055) ingress: 28.1s 27.0s 25.1s 28.6s 27.2s

Times for minikube start: 52.0s 50.8s 52.9s 50.9s 51.5s
Times for minikube (PR 17055) start: 165.1s 51.0s 52.1s 52.1s 50.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 22.7s               |
| enable ingress | 20.2s    | 19.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.8s 20.3s 18.8s 20.3s 20.8s
Times for minikube (PR 17055) ingress: 20.8s 20.8s 17.8s 20.8s 18.8s

Times for minikube start: 23.6s 22.2s 24.6s 24.8s 24.8s
Times for minikube (PR 17055) start: 21.0s 21.2s 22.5s 24.8s 24.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.3s               |
| enable ingress | 41.5s    | 30.5s               |
+----------------+----------+---------------------+

Times for minikube start: 19.7s 21.0s 23.8s 24.0s 20.4s
Times for minikube (PR 17055) start: 20.0s 20.6s 22.3s 22.9s 20.9s

Times for minikube ingress: 80.3s 30.3s 18.3s 47.3s 31.3s
Times for minikube (PR 17055) ingress: 31.3s 30.3s 30.3s 30.3s 30.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux TestDownloadOnly/v1.16.0/json-events (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CloudSpanner (gopogh) 1.43 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@spowelljr spowelljr closed this Jan 29, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 51.9s    | 50.8s               |
| enable ingress | 27.5s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 49.6s 51.9s 53.0s 52.7s 52.4s
Times for minikube (PR 17055) start: 51.7s 48.3s 50.5s 51.4s 52.0s

Times for minikube ingress: 28.7s 27.6s 26.6s 26.7s 27.7s
Times for minikube (PR 17055) ingress: 28.2s 24.1s 27.7s 28.1s 27.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 24.3s               |
| enable ingress | 19.6s    | 19.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 17055) start: 25.8s 22.5s 25.7s 22.1s 25.5s
Times for minikube start: 25.1s 22.6s 21.5s 21.4s 21.7s

Times for minikube ingress: 20.3s 20.3s 18.8s 17.9s 20.8s
Times for minikube (PR 17055) ingress: 20.9s 20.8s 20.3s 17.8s 17.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 22.1s               |
| enable ingress | 30.9s    | 34.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 20.9s 24.2s 23.6s 20.6s
Times for minikube (PR 17055) start: 20.4s 23.9s 20.1s 22.7s 23.3s

Times for minikube ingress: 30.3s 31.3s 30.4s 31.3s 31.3s
Times for minikube (PR 17055) ingress: 30.3s 32.4s 47.3s 31.4s 30.3s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 51.4s    | 50.4s               |
| enable ingress | 26.7s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.6s 27.1s 27.5s 23.6s 27.6s
Times for minikube (PR 17055) ingress: 28.0s 26.1s 26.6s 27.1s 27.1s

Times for minikube (PR 17055) start: 49.1s 50.3s 50.8s 51.6s 50.2s
Times for minikube start: 50.9s 51.0s 54.6s 49.8s 50.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 23.3s               |
| enable ingress | 19.5s    | 20.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 21.5s 20.8s 21.4s 24.8s
Times for minikube (PR 17055) start: 24.1s 21.6s 21.6s 24.6s 24.8s

Times for minikube (PR 17055) ingress: 20.8s 20.8s 20.8s 21.3s 20.8s
Times for minikube ingress: 19.3s 18.8s 20.8s 20.8s 17.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17055) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 20.8s               |
| enable ingress | 34.1s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 20.5s 19.6s 23.6s 23.3s 20.9s
Times for minikube (PR 17055) start: 20.2s 21.1s 20.5s 22.3s 20.0s

Times for minikube ingress: 30.3s 30.3s 47.3s 31.3s 31.3s
Times for minikube (PR 17055) ingress: 32.3s 31.3s 32.3s 31.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 6.67 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 6.67 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 6.67 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 6.67 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 6.67 (chart)
KVM_Linux_crio TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 6.67 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 12.50 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 12.50 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 12.50 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 12.50 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 12.50 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 12.50 (chart)
Docker_Linux_docker_arm64 TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 12.50 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 13.33 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 13.33 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 13.33 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 13.33 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 13.33 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 13.33 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 13.33 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 13.33 (chart)
Docker_Linux_crio_arm64 TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 13.33 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio_arm64 TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Docker_macOS TestCertOptions (gopogh) 0.00 (chart)
Docker_macOS TestDockerFlags (gopogh) 0.00 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 0.00 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 0.00 (chart)
KVM_Linux_crio TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/serial/LogsFileCmd (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 5.88 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 5.88 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 5.88 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 5.88 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 5.88 (chart)
KVM_Linux_crio TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 5.88 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 6.25 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 6.25 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 6.25 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 6.25 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 6.25 (chart)
KVM_Linux TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 6.25 (chart)
KVM_Linux TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 6.25 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/ComponentHealth (gopogh) 11.76 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/ExtraConfig (gopogh) 11.76 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 11.76 (chart)
Docker_Linux_containerd TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 12.50 (chart)
Docker_Linux_containerd TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 12.50 (chart)
Docker_Linux_containerd TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 12.50 (chart)
Docker_Linux_containerd TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 12.50 (chart)
Docker_Linux_containerd TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 12.50 (chart)
Docker_Linux_containerd TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 12.50 (chart)
Docker_Linux_containerd TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 12.50 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh Awaiting requested review from medyagh

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@minikube-bot @k8s-ci-robot @medyagh @minikube-pr-bot @spowelljr