Skip to content

Commit

Permalink
KEP 1645: slightly relax the managed by requirements on EndpointSlices
Browse files Browse the repository at this point in the history
Relax a bit the sentence about EndpointSlice marked as not managed by
the endpointslice controller as some EndpointSlice might be actually
managed by the endpointslice controller directly. For instance Cilium
implementation currently uses the default endpointslice controller to
manage the EndpointSlice from the local cluster.

The sentence below still implies that imported EndpointSlice must be
managed by a MCS-API controller which means that this mixed scenario can
be conformant while still keeping a strong guideline for EndpointSlice
managed by a MCS-API controller.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
  • Loading branch information
MrFreezeex committed Oct 24, 2024
1 parent c906d61 commit 3babc13
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -880,9 +880,9 @@ When a `ServiceExport` is created, this will cause `EndpointSlice` objects for
the underlying `Service` to be created in each importing cluster within the
clusterset, associated with the derived `ServiceImport`. One or more
`EndpointSlice` resources will exist for the exported `Service`, with each
`EndpointSlice` containing only endpoints from a single source cluster. These
`EndpointSlice` objects will be marked as managed by the clusterset service
controller, so that the endpoint slice controller doesn’t delete them.
`EndpointSlice` containing only endpoints from a single source cluster. An
`EndpointSlice` created by a mcs-controller must not be marked as managed by the
default `EndpointSlice` controller to avoid any conflicts between both controllers.
When a service is un-exported, the associated EndpointSlices will be deleted.
The specific mechanism by which they are deleted is an implementation detail.
Expand Down

0 comments on commit 3babc13

Please sign in to comment.