Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ make sure vsphere cloud provider pod restart gracefully only on modify event #1213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ make sure vsphere cloud provider pod restart gracefully only on modify event #1213

wants to merge 1 commit into from

Conversation

XudongLiuHarold
Copy link
Member

What this PR does / why we need it:

  • ensure the pod restarting gracefully
  • ensure the pod will only restart on watched file modify event

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1212

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2024
@XudongLiuHarold
Copy link
Member Author

team-cluster-api#25

12345lcr
12345lcr approved these changes Aug 23, 2024
View reviewed changes
Copy link

@12345lcr 12345lcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline discussed with Xudong and this looks good to me. Perhaps only Remove event should be handled, since the watched file is a symlink and the link path is changed every time when the file is changed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 12345lcr, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XudongLiuHarold
Copy link
Member Author

/hold

Will do more tests to see if watch real files is a better approach for us

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2024
@XudongLiuHarold
Copy link
Member Author

/hold cancel

I'd prefer keeping fsnotify to avoid a larger refactor for switching to viper

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12345lcr 12345lcr 12345lcr approved these changes

@divyenpatel divyenpatel Awaiting requested review from divyenpatel

@YanzhaoLi YanzhaoLi Awaiting requested review from YanzhaoLi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloud provider vsphere pod didn't restart gracefully as expected
3 participants
@XudongLiuHarold @k8s-ci-robot @12345lcr